Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #1415 #1418 to v1.3-branch #1428

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Oct 3, 2021

Part of #1425

Cherry-pick following PRs to finalize the v1.3.0 release

Feature/support pytorchjob set queue of volcano (#1415)
fix hyperlinks in the 'overview' section (#1418)

/cc @kubeflow/wg-training-leads

@google-oss-robot google-oss-robot requested a review from a team October 3, 2021 07:41
@google-cla
Copy link

google-cla bot commented Oct 3, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

* support pytorch use volcano-queue

* support pytorch use volcano-queue

Signed-off-by: bert.li <[email protected]>

* set SchedulingPolicy for runPolicy

Signed-off-by: bert.li <[email protected]>

* use pytorchjob.Spec.RunPolicy directly
hyperlinks now point to the latest api reference files.
issue - kubeflow#1411
@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit e0b872e into kubeflow:v1.3-branch Oct 3, 2021
@Jeffwan Jeffwan deleted the cherry_pick_fix branch October 3, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants